Maor Lipchuk has posted comments on this change. Change subject: core: introduce LibvirtSecret business entity ......................................................................
Patch Set 3: Code-Review+1 (1 comment) Generally ack, just one cosmetic question https://gerrit.ovirt.org/#/c/41549/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LibvirtSecret.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LibvirtSecret.java: Line 74: public boolean equals(Object o) { Line 75: if (this == o) return true; Line 76: if (o == null || getClass() != o.getClass()) return false; Line 77: Line 78: LibvirtSecret that = (LibvirtSecret) o; Is that auto-generated equals method? Why there are weird empty lines? Line 79: Line 80: if (id != null ? !id.equals(that.id) : that.id != null) return false; Line 81: if (value != null ? !value.equals(that.value) : that.value != null) return false; Line 82: if (usageType != that.usageType) return false; -- To view, visit https://gerrit.ovirt.org/41549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd26c1c1ac8328f6c5a82d9531afa3ff3d0ff837 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
