Oved Ourfali has posted comments on this change. Change subject: events: vm stats refresher refactioring ......................................................................
Patch Set 16: (4 comments) https://gerrit.ovirt.org/#/c/37487/16//COMMIT_MSG Commit Message: Line 7: refactoring https://gerrit.ovirt.org/#/c/37487/16/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java: Line 8: import org.ovirt.engine.core.utils.timer.OnTimerMethodAnnotation; Line 9: import org.ovirt.engine.core.utils.timer.SchedulerUtil; Line 10: Line 11: public class PollVMStatsRefresher implements VMStatsRefresher { Line 12: I'd remove the "this."... but it is a matter of style. Line 13: private VdsManager manager; Line 14: private SchedulerUtil sched; Line 15: private String vmsMonitoringJobId; Line 16: private int refreshIteration = 1; https://gerrit.ovirt.org/#/c/37487/16/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VMStatsRefresher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VMStatsRefresher.java: Line 1: package org.ovirt.engine.core.vdsbroker; Line 2: Line 3: public interface VMStatsRefresher { consider adding javadoc Line 4: void startMonitoring(); Line 5: void stopMonitoring(); Line 6: void perform(); Line 7: void updateIteration(); https://gerrit.ovirt.org/#/c/37487/16/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 60: import org.ovirt.engine.core.vdsbroker.vdsbroker.VDSNetworkException; Line 61: import org.ovirt.engine.core.vdsbroker.vdsbroker.VDSRecoveringException; Line 62: import org.slf4j.Logger; Line 63: import org.slf4j.LoggerFactory; Line 64: in this class there are no "this." usages, so please follow the current class convention. Line 65: public class VdsManager { Line 66: private static Logger log = LoggerFactory.getLogger(VdsManager.class); Line 67: private static Map<Guid, String> recoveringJobIdMap = new ConcurrentHashMap<Guid, String>(); Line 68: private final Object lockObj = new Object(); -- To view, visit https://gerrit.ovirt.org/37487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40139f9c90bd9ceeb297adf9f8bd3ab7f9113930 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
