Tal Nisan has posted comments on this change. Change subject: webadmin: Size info in GB along side % ......................................................................
Patch Set 8: Code-Review-1 (1 comment) Small comment but I think it might be wise to change it for future usages https://gerrit.ovirt.org/#/c/40729/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java: Line 146: public void setWarningLowSpaceIndicator(Integer warningLowSpaceIndicator) { Line 147: staticData.setWarningLowSpaceIndicator(warningLowSpaceIndicator); Line 148: } Line 149: Line 150: public Integer getWarningLowSpaceSize() { Given the problems we've had with other properties of StorageDomain with converstion of Integer to int and the NPEs resulting I think it's best that the return type will be int as we never return null either way, please fix and I'll merge Line 151: return getWarningLowSpaceIndicator() == null ? 0 : getTotalDiskSize() * getWarningLowSpaceIndicator() / 100; Line 152: } Line 153: Line 154: public Integer getCriticalSpaceActionBlocker() { -- To view, visit https://gerrit.ovirt.org/40729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a4032a16909d66186e98d4535983fb8cce86f46 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
