Ori Liel has posted comments on this change. Change subject: restapi: Move OpenStackImageProviders remove from collection to entity ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41828/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProviderResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProviderResource.java: Line 42: } Line 43: Line 44: @Override Line 45: public Response remove() { Line 46: Provider provider = BackendExternalProviderHelper.getProvider(this, id); Notice that no need to add get() call here because BackendExternalProviderHelper.getProvider(this, id) returns 404 if the provider isn't found. Line 47: ProviderParameters parameters = new ProviderParameters(provider); Line 48: return performAction(VdcActionType.RemoveProvider, parameters); Line 49: } -- To view, visit https://gerrit.ovirt.org/41828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e3955373f22e8ccf9ba3a3ae874c1489e0db9e3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
