Moti Asayag has posted comments on this change. Change subject: core: VdcActionParametersBase - choose if command is ended by parent ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41689/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java: Line 301: Line 302: public boolean isShouldBeEndedByParent() { Line 303: return shouldBeEndedByParent; Line 304: } Line 305: that would allow the clients to determine how the command should be executed. Is it desirable ? Or should it be restricted for internal commands ? Line 306: public void setShouldBeEndedByParent(boolean shouldBeEndedByParent) { Line 307: this.shouldBeEndedByParent = shouldBeEndedByParent; Line 308: } -- To view, visit https://gerrit.ovirt.org/41689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5342bee4989b44a878205c2d6094454b6ef5b2e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
