Maor Lipchuk has uploaded a new change for review. Change subject: core: Re-extract diskImageDynamic BaseImagesCommand ......................................................................
core: Re-extract diskImageDynamic BaseImagesCommand Re-extract code for DiskImageDynamic from addDiskImageToDb to be used in a seperate dedicated method. Change-Id: I458db364b5332450ad5e2f252d274a9cd565239e Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipc...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/41819/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java index e04372d..577c51a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java @@ -246,10 +246,7 @@ protected void addDiskImageToDb(DiskImage image, CompensationContext compensationContext, boolean active) { image.setActive(active); getImageDao().save(image.getImage()); - DiskImageDynamic diskDynamic = new DiskImageDynamic(); - diskDynamic.setId(image.getImageId()); - diskDynamic.setactual_size(image.getActualSizeInBytes()); - getDiskImageDynamicDAO().save(diskDynamic); + DiskImageDynamic diskDynamic = updateDiskImageDynamicIntoDB(image); ImageStorageDomainMap imageStorageDomainMap = new ImageStorageDomainMap(image.getImageId(), image.getStorageIds().get(0), image.getQuotaId(), image.getDiskProfileId()); getImageStorageDomainMapDao().save(imageStorageDomainMap); @@ -265,6 +262,14 @@ } } + protected DiskImageDynamic updateDiskImageDynamicIntoDB(DiskImage image) { + DiskImageDynamic diskDynamic = new DiskImageDynamic(); + diskDynamic.setId(image.getImageId()); + diskDynamic.setactual_size(image.getActualSizeInBytes()); + getDiskImageDynamicDAO().save(diskDynamic); + return diskDynamic; + } + /** * Save the disk from the given image info, only if the disk doesn't exist already. * @param image -- To view, visit https://gerrit.ovirt.org/41819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I458db364b5332450ad5e2f252d274a9cd565239e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
