Ori Liel has posted comments on this change. Change subject: restapi: Move Affinity Group VM remove from collection to entity ......................................................................
Patch Set 1: Code-Review+2 (2 comments) https://gerrit.ovirt.org/#/c/41801/1/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AffinityGroupVmsResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AffinityGroupVmsResource.java: Line 15 Line 16 Line 17 Line 18 Line 19 What's the reason for removing 'public'? https://gerrit.ovirt.org/#/c/41801/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupVmResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupVmResource.java: Line 12: import javax.ws.rs.WebApplicationException; Line 13: import javax.ws.rs.core.Response; Line 14: Line 15: public class BackendAffinityGroupVmResource Line 16: extends AbstractBackendActionableResource<VM, org.ovirt.engine.core.common.businessentities.VM> Might be better to extend BackendResource. No need for doPopulate() which exists for GET (no GET here) Line 17: implements AffinityGroupVmResource { Line 18: Line 19: private Guid groupId; Line 20: -- To view, visit https://gerrit.ovirt.org/41801 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id474459945434e0b44ab17ab389e1c86ee731e9f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
