Daniel Erez has posted comments on this change. Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks ......................................................................
Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/39471/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java: Line 61: Line 62: private CinderBroker cinderBroker; Line 63: Line 64: @Inject Line 65: private VmDAO vmDAO; > please maintain camelCase (vmDao) Done Line 66: Line 67: @Inject Line 68: private VmDeviceDAO vmDeviceDAO; Line 69: Line 64: @Inject Line 65: private VmDAO vmDAO; Line 66: Line 67: @Inject Line 68: private VmDeviceDAO vmDeviceDAO; > same Done Line 69: Line 70: public AbstractDiskVmCommand(T parameters) { Line 71: this(parameters, null); Line 72: } https://gerrit.ovirt.org/#/c/39471/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HotPlugDiskVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HotPlugDiskVDSParameters.java: Line 61: @Override Line 62: protected ToStringBuilder appendAttributes(ToStringBuilder tsb) { Line 63: return super.appendAttributes(tsb) Line 64: .append("diskId", disk.getId()) Line 65: .append("addressMap", addressMap.toString()); > you should use Done Line 66: } -- To view, visit https://gerrit.ovirt.org/39471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e621618e8891fca52b48bff437cc4c2a1f695db Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
