Ori Liel has posted comments on this change. Change subject: engine: support non-unique vm and template names across DCs (#912263) ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/41263/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 141: Line 142: // VM Template based entities queries Line 143: IsVmTemlateWithSameNameExist(VdcQueryAuthType.User), Line 144: GetVmTemplate(VdcQueryAuthType.User), Line 145: GetInstanceType(VdcQueryAuthType.User), > are you sure this should be user query? where are you using it? I didn't put much thought into this, I saw that the equivalent query for getting a template (see 1 line above) is a user-query, so I did the same for instance type. Do you think it should be an admin query? Line 146: GetAllVmTemplates(VdcQueryAuthType.User), Line 147: GetAllInstanceTypes(VdcQueryAuthType.User), Line 148: GetAllImageTypes(VdcQueryAuthType.User), Line 149: GetVmTemplatesDisks(VdcQueryAuthType.User), -- To view, visit https://gerrit.ovirt.org/41263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f3244ec1885d54e58b475d0e74f59e26fa492a0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
