Juan Hernandez has posted comments on this change. Change subject: backend: Implementation support for GuestOsInfo and Timezone reporting ......................................................................
Patch Set 22: (3 comments) https://gerrit.ovirt.org/#/c/29322/22/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 3295: <xs:element name="kernel_version" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3296: <xs:element name="type" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3297: <xs:element name="version" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3298: </xs:sequence> Line 3299: </xs:complexType> We already have a "OPeratingSystemInfo" complex type that is currently used only to report the name of the operating system. I think it is better if we reuse it instead of introducing a new type. Line 3300: Line 3301: <xs:complexType name="GuestTimezone"> Line 3302: <xs:sequence> Line 3303: <xs:element name="name" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3302: <xs:sequence> Line 3303: <xs:element name="name" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3304: <xs:element name="offset" type="xs:int" minOccurs="1" maxOccurs="1"/> Line 3305: </xs:sequence> Line 3306: </xs:complexType> The VM already has a "timezone" property that is populated when the VM is created or edited. As the information provided by the guest agent is probably more accurate I think that it should replace what is provided via the GUI. This should happen in the backend, and thus there shouldn't be any change to the RESTAPI in this area. Line 3307: Line 3308: <xs:complexType name="GuestInfo"> Line 3309: <xs:sequence> Line 3310: <xs:element ref="ips" minOccurs="0" maxOccurs="1"/> Line 3311: <xs:element name="fqdn" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 3312: <xs:element name="timezone" type="GuestTimezone" minOccurs="0" maxOccurs="1"/> Line 3313: <xs:element name="guest_os" type="GuestOs" minOccurs="0" maxOccurs="1"/> Line 3314: </xs:sequence> Line 3315: </xs:complexType> This complete element is going to be removed in 4.x in favour of similar elements inside the VM complex type, refrain from using it. Line 3316: Line 3317: <xs:element name="serial_number" type="SerialNumber" /> Line 3318: Line 3319: <xs:complexType name="SerialNumber"> -- To view, visit https://gerrit.ovirt.org/29322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1e54d39706601c0faf9d76785f1257ee20755b Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
