Arik Hadas has posted comments on this change. Change subject: core: introduce v2v jobs ......................................................................
Patch Set 19: (3 comments) https://gerrit.ovirt.org/#/c/40650/19/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java: Line 343: public void setCpuOverCommitTimeStamp(Date value) { Line 344: cpuOverCommitTimeStamp = value; Line 345: } Line 346: Line 347: public List<V2VJobInfo> getV2VJobs() { > missing wrapping in VDS I think we should add it there once we will need it in the context of VDS. remember that this is only a temporary solution until we have events.. Line 348: return v2vJobs; Line 349: } Line 350: Line 351: public void setV2VJobs(List<V2VJobInfo> v2vJobs) { https://gerrit.ovirt.org/#/c/40650/19/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 1028: public void addV2VJobInfoForVm(Guid vmId, JobStatus jobStatus) { Line 1029: vmIdToV2VJob.put(vmId, new V2VJobInfo(vmId, jobStatus)); Line 1030: } Line 1031: Line 1032: void updateV2VJobInfos(List<V2VJobInfo> v2vJobInfos) { > please add some doc for this method Done Line 1033: for (V2VJobInfo existingJobInfo : vmIdToV2VJob.values()) { Line 1034: if (existingJobInfo.monitor() && !v2vJobInfos.contains(existingJobInfo)) { Line 1035: existingJobInfo.setStatus(JobStatus.ERROR); Line 1036: } https://gerrit.ovirt.org/#/c/40650/19/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 2078: try { Line 2079: String status = (String) input.get(VdsProperties.v2vJobStatus); Line 2080: return V2VJobInfo.JobStatus.valueOf(status.toUpperCase()); Line 2081: } catch (Exception e) { Line 2082: return V2VJobInfo.JobStatus.UNKNOWN; > maybe log a warning that there was an error and the value we received from Done Line 2083: } Line 2084: } -- To view, visit https://gerrit.ovirt.org/40650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id289c99db807a359b195127736326d9d1b1bbd23 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
