Arik Hadas has posted comments on this change.

Change subject: core: add timestamp for vm-dynamic updates
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/41520/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ManagingVmCommand.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ManagingVmCommand.java:

Line 15:     protected void executeVDSCommand() {
Line 16:         vmManager.lock();
Line 17:         try {
Line 18:             executeVmCommand();
Line 19:             
vmManager.setLastUpdateDate(Calendar.getInstance().getTime());
Note that a side effect of putting it here will be that every time the user 
changes CD, there is a chance to skip a cycle of the monitoring. Not the end of 
the world though
Line 20:         } finally {
Line 21:             vmManager.unlock();
Line 22:         }
Line 23:     }


-- 
To view, visit https://gerrit.ovirt.org/41520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If858993450cf957babdcf337e9b7867a282657bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to