Maor Lipchuk has posted comments on this change. Change subject: core: Introduce private class at Cinder validator. ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41461/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java: Line 68: private > perhaps worth extracting it to a public class? This class is an implementation detail for the CinderDisksValidator so there is no need to declare this class as a top level class. Though I see now that this class should be declared as static -- To view, visit https://gerrit.ovirt.org/41461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45c4584f336c606e48d51858d967b25cbd125aad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
