Maor Lipchuk has posted comments on this change. Change subject: core: Create cinder snapshot call back ......................................................................
Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/40978/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommandCallback.java: Line 40: super.onFailed(cmdId, childCmdIds); > probably worth adding a log done Line 41: > try to verify the negative flow, you might need to add: "getCommand().getPa done also added CommandCoordinatorUtil.removeAllCommandsInHierarchy(cmdId); Line 56: getDiskId > to avoid confusion, maybe worth using a different method (e.g. getImageId) done -- To view, visit https://gerrit.ovirt.org/40978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986b41aba646c84d0d9d7fe771957cba6faf777a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
