Arik Hadas has posted comments on this change. Change subject: webadmin: add template from snapshot ......................................................................
Patch Set 12: (3 comments) @Tomas, I fixed the first comment in this patch and the other two comments in a separate patch because: 1. I'm not sure if I fixed it the way you expected and I really want to merge this thing to be able to close the bug 2. For the changes you propose to be effective I also need to change VmListModel which is not related to this change, so I prefer to reduce the noise here The other patch is https://gerrit.ovirt.org/#/c/41639/ https://gerrit.ovirt.org/#/c/41259/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java: Line 672: (HelpTag.new_templat > you can not use this one since the definithion contains this: Done Line 747: new AddVmTemplateFromSnapshotParameters(newVm.getStaticData(), Line 748: model.getName().getEntity(), Line 749: model.getDescription().getEntity(), Line 750: getSelectedItem().getId()); Line 751: parameters.setPublicUse(model.getIsTemplatePublic().getEntity()); > I don't particularly like this copy-paste of the parameters creating... I'm Done (see Ibfbc42621) Line 752: Line 753: parameters.setDiskInfoDestinationMap( Line 754: model.getDisksAllocationModel().getImageToDestinationDomainMap()); Line 755: parameters.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity()); Line 783: VM resultVm = new VM(); Line 784: resultVm.setId(vm.getId()); Line 785: BuilderExecutor.build(model, resultVm.getStaticData(), new CommonUnitToVmBaseBuilder()); Line 786: BuilderExecutor.build(vm.getStaticData(), resultVm.getStaticData(), Line 787: new KernelParamsVmBaseToVmBaseBuilder(), > Similar to the thing above - please extract this 4 builders to one composit Done (see Ibfbc42621) Line 788: new DedicatedVmForVdsVmBaseToVmBaseBuilder(), Line 789: new MigrationOptionsVmBaseToVmBaseBuilder(), Line 790: new UsbPolicyVmBaseToVmBaseBuilder()); Line 791: return resultVm; -- To view, visit https://gerrit.ovirt.org/41259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcf50dce6c749008b03cb94cf666ba295b0b9da6 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
