Alexander Wels has uploaded a new change for review.

Change subject: webadmin: disk permissions never loads
......................................................................

webadmin: disk permissions never loads

- In commit d1060a824f1ea0b5a6efae486cad9ccbb6e6804a the type of the permissions
  changed from DiskListModel to Disk, however the bound type of the interface
  was never changed to match which caused the permissions to not be properly
  passed to the sub tab presenter and thus the view. This patch matches the
  interface to the correct type.

Change-Id: Ib583e92b4108081d65294e793637c7738e94cb08
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1219396
Signed-off-by: Alexander Wels <aw...@redhat.com>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/41603/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java
index 61967fd..609965d 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java
@@ -101,7 +101,7 @@
         bind(DiskVmListModel.class).in(Singleton.class);
         bind(DiskTemplateListModel.class).in(Singleton.class);
         bind(DiskStorageListModel.class).in(Singleton.class);
-        bind(new 
TypeLiteral<PermissionListModel<DiskListModel>>(){}).in(Singleton.class);
+        bind(new 
TypeLiteral<PermissionListModel<Disk>>(){}).in(Singleton.class);
 
         // Form Detail Models
         bind(new TypeLiteral<DetailModelProvider<DiskListModel, 
DiskGeneralModel>>(){})


-- 
To view, visit https://gerrit.ovirt.org/41603
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib583e92b4108081d65294e793637c7738e94cb08
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to