anmolbabu has posted comments on this change.

Change subject: webadmin : Fix Menu Cell click event
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/41528/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivityCompositeCell.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivityCompositeCell.java:

Line 36:                 if(consumedEvents != null) {
Line 37:                     set.addAll(consumedEvents);
Line 38:                 }
Line 39:             }
Line 40:             if(currentHasCell instanceof AbstractCell) {
> I think you can use the interface here -- "Cell" instead of "AbstractCell".
Done
Line 41:                 
set.addAll(((AbstractCell)currentHasCell).getConsumedEvents());
Line 42:             }
Line 43:         }
Line 44:         return set;


-- 
To view, visit https://gerrit.ovirt.org/41528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32a223494d23848c530ee083dc14e1d072a86967
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to