Eldan Shachar has posted comments on this change. Change subject: userportal/webadmin: cluster parameters override - UI enhancements ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/38407/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VerifyClusterSupportsVmCpuQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VerifyClusterSupportsVmCpuQuery.java: Line 6: import java.util.HashMap; Line 7: import java.util.List; Line 8: import java.util.Map; Line 9: Line 10: public class VerifyClusterSupportsVmCpuQuery<P extends VerifyClusterSupportsVmCpuParameters> extends QueriesCommandBase<P> { > maybe add a note what this query does Done Line 11: public VerifyClusterSupportsVmCpuQuery(P parameters) { Line 12: super(parameters); Line 13: } Line 14: https://gerrit.ovirt.org/#/c/38407/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java: Line 558: Line 559: @DefaultStringValue("Emulated Machine override") Line 560: String emulatedMachineLabel(); Line 561: Line 562: @DefaultStringValue("CPU Type override") > maybe would be better to change to "Custom CPU Type" (and "Custom Emulated Done Line 563: String cpuModelLabel(); Line 564: Line 565: @DefaultStringValue("Use cluster default") Line 566: String clusterDefaultOption(); -- To view, visit https://gerrit.ovirt.org/38407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e1c458dc4e4b6e61d2a1b92327287166a12afa2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
