Omer Frenkel has posted comments on this change.

Change subject: core: add configuration for hot plug memory
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/41138/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java:

Line 1823:     
@DefaultValueAttribute("{\"x86_64\":\"false\",\"ppc64\":\"false\"}")
Line 1824:     HotUnplugCpuSupported,
Line 1825: 
Line 1826:     @TypeConverterAttribute(Map.class)
Line 1827:     
@DefaultValueAttribute("{\"x86_64\":\"true\",\"ppc64\":\"false\"}")
> why disabled for ppc?
does it work for ppc? i assumed not because hot plug cpu is disabled
Line 1828:     HotPlugMemorySupported,
Line 1829: 
Line 1830:     @TypeConverterAttribute(Map.class)
Line 1831:     
@DefaultValueAttribute("{\"x86_64\":\"false\",\"ppc64\":\"false\"}")


-- 
To view, visit https://gerrit.ovirt.org/41138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5ca4b827ff8bbcdc1417677e98f908ac60fbc9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to