anmolbabu has posted comments on this change. Change subject: webadmin: Hiding virt network fields in gluster mode ......................................................................
Patch Set 3: (5 comments) https://gerrit.ovirt.org/#/c/41480/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java: Line 107: protected void onExportChanged() { Line 108: boolean externalNetwork = getExport().getEntity(); Line 109: getExternalProviders().setIsChangeable(externalNetwork); Line 110: getIsVmNetwork().setIsChangeable(!externalNetwork && isSupportBridgesReportByVDSM() Line 111: && ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly)); why this is required? It is invisible in Gluster-only mode right? Line 112: if (externalNetwork) { Line 113: getIsVmNetwork().setEntity(true); Line 114: } Line 115: https://gerrit.ovirt.org/#/c/41480/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java: Line 431: Line 432: @Override Line 433: public void updateVisibility() { Line 434: messageLabel.setVisible(false); Line 435: if (ApplicationModeHelper.getUiMode() == ApplicationMode.GlusterOnly) { Both are equivalent but Kanagaraj generally prefers use of !ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly) :) Line 436: externalProviderEditor.setVisible(false); Line 437: neutronPhysicalNetwork.setVisible(false); Line 438: createSubnetEditor.setVisible(false); Line 439: vlanTagging.setVisible(false); https://gerrit.ovirt.org/#/c/41480/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java: Line 73: getTable().addColumnWithHtmlHeader(commentColumn, Line 74: SafeHtmlUtils.fromSafeConstant(constants.commentLabel()), Line 75: "75px"); //$NON-NLS-1$ Line 76: Line 77: if (ApplicationModeHelper.getUiMode() != ApplicationMode.GlusterOnly) { ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly) :) Line 78: AbstractTextColumn<NetworkView> dcColumn = new AbstractTextColumn<NetworkView>() { Line 79: @Override Line 80: public String getValue(NetworkView object) { Line 81: return object.getDataCenterName(); Line 125: }; Line 126: Line 127: getTable().addColumn(roleColumn, constants.roleNetwork(), "60px"); //$NON-NLS-1$ Line 128: Line 129: if (ApplicationModeHelper.getUiMode() != ApplicationMode.GlusterOnly) { same as above Line 130: AbstractTextColumn<NetworkView> vlanColumn = new AbstractTextColumn<NetworkView>() { Line 131: @Override Line 132: public String getValue(NetworkView object) { Line 133: return object.getVlanId() == null ? "-" : object.getVlanId().toString(); //$NON-NLS-1$ Line 152: return object.getProvidedBy() == null ? "" : object.getProviderName(); //$NON-NLS-1$ Line 153: } Line 154: }; Line 155: providerColumn.makeSortable(NetworkConditionFieldAutoCompleter.PROVIDER_NAME); Line 156: if (ApplicationModeHelper.getUiMode() != ApplicationMode.GlusterOnly) { same as above Line 157: getTable().addColumn(providerColumn, constants.providerNetwork(), "200px"); //$NON-NLS-1$ Line 158: } Line 159: Line 160: -- To view, visit https://gerrit.ovirt.org/41480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9380697adc0c6e1d698e7aacc1f9b47be0d3851 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
