Sandro Bonazzola has posted comments on this change. Change subject: hostdev: add support for enabling IOMMU on the host ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/41507/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-05-27 15:13:17 +0200 Line 6: Line 7: hostdev: add support for enabling IOMMU on the host Line 8: Line 9: The pci passthrough feature requires a host that supports VFIO driver. Please add a link to the feature. Line 10: The support is configured via BIOS and kernel - we cannot really deal Line 11: with BIOS, but we can configure the kernel. Line 12: Line 13: The configuration is done by adding {intel_iommu, amd_iommu}=on to https://gerrit.ovirt.org/#/c/41507/3/src/plugins/ovirt-host-deploy/hostdev/iommu.py File src/plugins/ovirt-host-deploy/hostdev/iommu.py: Line 102: self._regenerate_grub() Line 103: Line 104: def _update_grub_conf(self): Line 105: content = '' Line 106: with open(odeploycons.FileLocations.GRUB_CONFIG_FILE, 'r') as f: why using /etc/default/grub ? this is something the user can change at will and may affect the feature or compromise system boot. why not adding a new entry in grub? you can add a new boot entry adding a file in /etc/grub.d If grub2 is there, it will be taken and user can boot from selecting the new entry instead of compromising existing ones. if user doesn't want to use our command line he still has his own default. if grub2 is not there, it will just be ignored. Line 107: for line in f: Line 108: if 'GRUB_CMDLINE_LINUX' in line: Line 109: content += ( Line 110: line.rstrip('"\n') + '%s=on"\n' % self._CMDLINE_IOMMU[ -- To view, visit https://gerrit.ovirt.org/41507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceb4cf0a548cd9ffacb47afb825217042832c36f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
