[Engine-patches] Change in ovirt-engine[master]: core: revert the remove of a check in VdsSelector

[rgolan]

Roy Golan has uploaded a new change for review.

Change subject: core: revert the remove of a check in VdsSelector
......................................................................

core: revert the remove of a check in VdsSelector

Accidentally removed a check in VdsSelector due to refactoring

Change-Id: I70b9bfa8cb6edf3b8833a0b9ee71fe9487f967e9
Signed-off-by: Roy Golan <rgo...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
1 file changed, 26 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/13/8713/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
index 1781231..13c36d1 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
@@ -335,6 +335,17 @@
                     return null;
                 }
             });
+            add(new HostValidator() {
+
+                @Override
+                public VdcBllMessages validate(VDS vds, StringBuilder sb) {
+                    if (isVdsFailedToRunVm(vds.getId())) {
+                        sb.append("have failed running this VM in the current 
selection cycle");
+                        return 
VdcBllMessages.ACTION_TYPE_FAILED_VDS_VM_CLUSTER;
+                    }
+                    return null;
+                }
+            });
         }
     });
 
@@ -353,6 +364,21 @@
     }
 
     /**
+     * Determine if specific vds already failed to run vm - to prevent
+     * sequentual running of vm on problematic vds
+     *
+     * @param vdsId
+     * @return
+     */
+    private boolean isVdsFailedToRunVm(Guid vdsId) {
+        boolean retValue = false;
+        if (getRunVdssList() != null && getRunVdssList().contains(vdsId)) {
+            retValue = true;
+        }
+        return retValue;
+    }
+
+    /**
      * Determines whether [is VM swap value legal] [the specified VDS].
      *
      * @param vds


--
To view, visit http://gerrit.ovirt.org/8713
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I70b9bfa8cb6edf3b8833a0b9ee71fe9487f967e9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches