Daniel Erez has posted comments on this change. Change subject: core: Validate maximum cinder snapshot once creating a snapshot. ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41133/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 197: Line 198: public boolean validateCinder() { Line 199: List<CinderDisk> cinderDisks = ImagesHandler.filterDisksBasedOnCinder(DbFacade.getInstance().getDiskDao().getAllForVm(getVmId())); Line 200: if (!cinderDisks.isEmpty()) { Line 201: CinderDisksValidator cinderDisksValidator = new CinderDisksValidator(cinderDisks); please extract to createCinderDiskValidator Line 202: return validate(cinderDisksValidator.validateCinderDiskSnapshotsLimits()); Line 203: } Line 204: return true; Line 205: } -- To view, visit https://gerrit.ovirt.org/41133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0120320f3bbb8570e7b9c7b4300b9617ccf73e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
