Daniel Erez has posted comments on this change. Change subject: core: Introduce remove Cinder snapshot call back ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41459/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderSnapshotCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderSnapshotCommandCallback.java: Line 46: DiskImage previousSnapshot = getDiskImageDAO().getSnapshotById(getDisk().getParentId()); Line 47: previousSnapshot.setActive(true); Line 48: getImageDao().update(previousSnapshot.getImage()); Line 49: } Line 50: onFinish(cmdId); check if need to add: " getCommand().getParameters().setTaskGroupSuccess(false); " Line 51: } Line 52: Line 53: @Override Line 54: public void onSucceeded(Guid cmdId, List<Guid> childCmdIds) { -- To view, visit https://gerrit.ovirt.org/41459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba139eacc85b958b7f6475d1dbb1680d0c44513c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
