Tomas Jelinek has posted comments on this change.

Change subject: restapi: added support for io_threads
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/40094/4/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java:

Line 168:         staticVm.setMigrationDowntime(entity.getMigrationDowntime());
Line 169:         staticVm.setMinAllocatedMem(entity.getMinAllocatedMem());
Line 170:         if (FeatureSupported.isIoThreadsSupported(clusterVersion)) {
Line 171:             staticVm.setNumOfIoThreads(entity.getNumOfIoThreads());
Line 172:         }
> Ok, I understand. The problem is that we aren't passing the InstanceType ob
ok, but it is a refactoring unrelated to this change. I will try to do it later
Line 173:         return staticVm;
Line 174:     }
Line 175: 
Line 176:     @Mapping(from = VM.class, to = VmStatic.class)


-- 
To view, visit https://gerrit.ovirt.org/40094
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e6f9b76d424027ef21e17cc3b3c9ffd7023b52d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to