Arik Hadas has posted comments on this change. Change subject: core: introduce convert-vm command ......................................................................
Patch Set 82: @Oved, that's something we considered and decided that it not better than this implementation. The drawbacks (that I remember) we talked about are: 1. adding an extra verb to vdsm - the feature freeze for 3.6 is approaching and we want to stabilize the API we already implemented in VDSM 2. adding an extra verb means another round-trip to VDSM which is not required. The thread in command-coordination that executes the do-polling will have to be blocked while calling this verb - it does not look like a good design. So we were thinking about it and decided that for 3.6 we will continue with the way it is already implemented in VDSM. We might consider to change it later on, but currently we want to concentrate on implementing the things that are still missing for 3.6 and not to redesign things that work. -- To view, visit https://gerrit.ovirt.org/33055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bc67ff237d5c01fc5f3c9f21c822573e5db32a3 Gerrit-PatchSet: 82 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
