Moti Asayag has posted comments on this change. Change subject: core: Move Job, Step to JPA ......................................................................
Patch Set 53: (2 comments) https://gerrit.ovirt.org/#/c/34553/53/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java: Line 53: + "and ((j.endTime < :failedEndTime and j.status in (:failStatus)) " Line 54: + "or (j.endTime < :successEndTime and j.status = :successStatus))"), Line 55: @NamedQuery( Line 56: name = "Job.deleteJobOlderThanDateWithStatus", Line 57: query = "delete from Job j where j.autoCleared = true and j.endTime < :sinceDate and j.status in (:statuses)") please format the query, so it won't exceed line's limit Line 58: }) Line 59: public class Job extends IVdcQueryable implements BusinessEntity<Guid> { Line 60: Line 61: /** https://gerrit.ovirt.org/#/c/34553/53/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java: Line 32: */ Line 33: @Entity Line 34: @Table(name = "step") Line 35: @Cacheable(true) Line 36: @NamedQueries({ please format the queries, so it won't exceed line's limit and maintain it readability Line 37: @NamedQuery( Line 38: name = "Step.updateJobStepsCompleted", Line 39: query = "update Step s set s.status = :status, s.endTime = :endTime where s.status = :startedStatus and s.jobId = :jobId"), Line 40: @NamedQuery( -- To view, visit https://gerrit.ovirt.org/34553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcfda7b055d37c92c1346b100101c27d594d21fb Gerrit-PatchSet: 53 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
