Arik Hadas has posted comments on this change. Change subject: core: removed redundant initializers, unused parameters, explicit type parameters ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41272/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java: Line 182: public List<RepoImage> getUserRequestForStorageDomainRepoFileList(Guid storageDomainId, Line 183: ImageFileType imageType, Line 184: boolean forceRefresh) { Line 185: // The result list we send back. Line 186: List<RepoImage> repoList; no need for this variable, we can just return the returned value from the call to getCachedIsoListByDomainId Line 187: if (!isStorageDomainValid(storageDomainId, imageType, forceRefresh)) { Line 188: throw new VdcBLLException(VdcBllErrors.GetIsoListError); Line 189: } Line 190: // At any case, if refreshed or not, get Iso list from the cache. -- To view, visit https://gerrit.ovirt.org/41272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64bc644328eef2a88c0bc61f5589693350696659 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
