Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin : Fix volume main and sub tab column id issue
......................................................................
webadmin : Fix volume main and sub tab column id issue
This patch does the following,
1. Adding column's to MainTabVolumeView require columns to override
AbstractColumn or handle id on own. But overriding AbstractColumn
provides base implementation for ColumnWithElementId#configureElementId
which actually assigns ids for columns.
Accordingly changes are performed in,
[i] Changed VolumeActivityColumn
2. Now, ApplicationTemplates#statusTemplate takes a SafeHtml and a
string id. Some of the cells corrected as part of this patch used to
treat tooltips as ids and now this patch corrects it by adding new
templates to ApplicationTemplate for handling tooltip requiring images
and also handles ids for such columns.
Accordingly changes are performed in,
[i] GlusterCapacityCell and hence VolumeCapacityCell and
BrickCapacityCell
[ii] VolumeInfoCell
Change-Id: Ifded690b427ba8eb17bba272360f916850f76891
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1220393
Signed-off-by: Anmol Babu <anb...@redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeCapacityCell.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeInfoCell.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickCapacityCell.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterCapacityCell.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityColumn.java
6 files changed, 19 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
anmolbabu: Verified
Kanagaraj M: Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41387
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifded690b427ba8eb17bba272360f916850f76891
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
