Mike Kolesnik has posted comments on this change.
Change subject: core: New AssertUtils Class
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/AssertUtils.java
Line 10: * A utility class for static asserting methods.
Line 11: */
Line 12: public class AssertUtils {
Line 13:
Line 14: public static <T> void assertEqualsIgnoreOrder(List<T> list1,
List<T> list2) {
Since you ignore order anyway, and there is no real significance for passing
List, you can receive 2 Collections and compare them.
Then a more appropriate name would be assertCollectionsEqual and javadoc can be
added to explain what it does.
Line 15: assertNotNull(list1);
Line 16: assertNotNull(list2);
Line 17: assertEquals(list1.size(), list2.size());
Line 18: for (T element : list1) {
--
To view, visit http://gerrit.ovirt.org/8698
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b8ab50adc2b9866b9c15414905a79bdce903f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
