Maor Lipchuk has uploaded a new change for review.

Change subject: core: Add validator in CinderBroker for snapshot exists.
......................................................................

core: Add validator in CinderBroker for snapshot exists.

Add validaor when removing a snapshot.

Change-Id: I805f1258014142cc2d1a4491d051b62f50671395
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
1 file changed, 17 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/41458/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
index ae7e0f7..e993598 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
@@ -197,6 +197,23 @@
         });
     }
 
+    public boolean isSnapshotExist(final Guid id) {
+        return execute(new Callable<Boolean>() {
+            @Override
+            public Boolean call() {
+                try {
+                    Snapshot snapshot = proxy.getSnapshotById(id.toString());
+                    return snapshot != null;
+                } catch (OpenStackResponseException ex) {
+                    if (ex.getStatus() == HttpStatus.SC_NOT_FOUND) {
+                        return false;
+                    }
+                    throw ex;
+                }
+            }
+        });
+    }
+
     public ImageStatus getSnapshotStatus(final Guid id) {
         return execute(new Callable<ImageStatus>() {
             @Override


-- 
To view, visit https://gerrit.ovirt.org/41458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I805f1258014142cc2d1a4491d051b62f50671395
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to