Ramesh N has posted comments on this change. Change subject: gluster: Correct canDoAction message for volume snapshot actions ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41247/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java: Line 202: volume.getAsyncTask().getType() == GlusterTaskType.REBALANCE : || volume.getAsyncTask().getType() == GlusterTaskType.REMOVE_BRICK) Do we need to consider the task status as well. If there is a task on the volume but the task is either completed or stopped , we should all the snapshot create i think. -- To view, visit https://gerrit.ovirt.org/41247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If311d43f9266c7717891b4698fc041529007532f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
