Itamar Heim has posted comments on this change. Change subject: [WIP] core: adding unlock_disks.sh script ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/dbscripts/unlock_disks.sh Line 34: t) TYPE=$OPTARG;; Line 35: i) ID=$OPTARG;; Line 36: s) SERVERNAME=$OPTARG;; Line 37: p) PORT=$OPTARG;; Line 38: d) DATABASE=$OPTARG;; is db, server, port, username mandatory, or by default come from pgpass? if not from pgpass, how is password handled? Line 39: u) USERNAME=$OPTARG;; Line 40: l) LOGFILE=$OPTARG;; Line 41: v) VERBOSE=true;; Line 42: h) ret=0 && usage;; -- To view, visit http://gerrit.ovirt.org/8688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
