Ramesh N has posted comments on this change. Change subject: gluster: display error message when sync storage device fails ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/40844/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java: Line 91: } catch (Exception e) { Line 92: log.error("Exception retriving storage device from vds {}", e.getMessage()); Line 93: log.debug("Exception", e); Line 94: throw e; Line 95: } > Above, there are two ways of handling the error. In which case 'catch' will I am not sure when Exception will come and when getSucceeded will be false. Anyway I am handling the null and exception. Line 96: Line 97: } Line 98: Line 99: private void updateStorageDevices(VDS vds, List<StorageDevice> storageDevicesFromVdsm) { Line 119: storageDevicesFromVdsm > possible NPE Done -- To view, visit https://gerrit.ovirt.org/40844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib05b3f0bcaa95fb50440c939f6b07ade9ba8879c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
