Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Modify webadmin and userportal to use enginesso for 
authentication
......................................................................


Patch Set 47:

(1 comment)

https://gerrit.ovirt.org/#/c/36619/47/packaging/services/ovirt-engine/ovirt-engine.conf.in
File packaging/services/ovirt-engine/ovirt-engine.conf.in:

Line 258: 
Line 259: #
Line 260: # Error page
Line 261: #
Line 262: ERROR_PAGE=/${ENGINE_URI}/error.html
be consistent with _URL suffix for urls?

also I am unsure about the leading /
Line 263: 
Line 264: #
Line 265: # SSO Configuration
Line 266: #


-- 
To view, visit https://gerrit.ovirt.org/36619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff0aee9d0f5ee606ff7f397cab69017ca7d9df08
Gerrit-PatchSet: 47
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to