[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Corrected setting of gluster volume snapshot config

[shtripat]

Shubhendu Tripathi has uploaded a new change for review.

Change subject: gluster: Corrected setting of gluster volume snapshot config
......................................................................

gluster: Corrected setting of gluster volume snapshot config

The gluster CLI command for setting gluster volume snapshot
option snap-max-soft-limit does not accept '%' sign in the
last. Corrected the code to remove the same if passed from
UI.

Change-Id: I9c5f425e9acd63646aad5ed4535cbc334c7b41aa
Signed-off-by: Shubhendu Tripathi <shtri...@redhat.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeSnapshotConfigVDSCommand.java
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/41324/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeSnapshotConfigVDSCommand.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeSnapshotConfigVDSCommand.java
index e9ba13f..99c901b 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeSnapshotConfigVDSCommand.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeSnapshotConfigVDSCommand.java
@@ -1,5 +1,6 @@
 package org.ovirt.engine.core.vdsbroker.gluster;
 
+import org.apache.commons.lang.StringUtils;
 import 
org.ovirt.engine.core.common.businessentities.gluster.GlusterVolumeEntity;
 import 
org.ovirt.engine.core.common.businessentities.gluster.GlusterVolumeSnapshotConfig;
 import 
org.ovirt.engine.core.common.vdscommands.gluster.GlusterVolumeSnapshotSetConfigVDSParameters;
@@ -22,14 +23,15 @@
         GlusterVolumeSnapshotConfig cfgParam = getParameters()
                 .getConfgParam();
 
+        String paramValue = StringUtils.removeEnd(cfgParam.getParamValue(), 
"%");
         if (cfgParam.getVolumeId() != null) {
             GlusterVolumeEntity volume = 
DbFacade.getInstance().getGlusterVolumeDao().getById(cfgParam.getVolumeId());
             status =
                     
getBroker().glusterVolumeSnapshotConfigSet(volume.getName(),
                             cfgParam.getParamName(),
-                            cfgParam.getParamValue());
+                            paramValue);
         } else {
-            status = 
getBroker().glusterSnapshotConfigSet(cfgParam.getParamName(), 
cfgParam.getParamValue());
+            status = 
getBroker().glusterSnapshotConfigSet(cfgParam.getParamName(), paramValue);
         }
 
         proceedProxyReturnValue();


-- 
To view, visit https://gerrit.ovirt.org/41324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c5f425e9acd63646aad5ed4535cbc334c7b41aa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches