Liron Aravot has posted comments on this change. Change subject: [WIP] webadmin, core: Use NFS v3 as default ......................................................................
Patch Set 4: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/DefaultValueMap.java Line 1: package org.ovirt.engine.core.utils.collections; Line 2: Line 3: import java.util.HashMap; Line 4: I'd suggest using here the Decorater pattern instead so we can use that logic with pre existing maps and also to not limit outselves only to hashmap implementation. Line 5: /** Line 6: * A utility class providing a <String, String> map with methods useful for Line 7: * handling default and empty values. Line 8: */ -- To view, visit http://gerrit.ovirt.org/8242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I831ecc7050a5487d5365efb94342a3c170dddc6c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
