Moti Asayag has posted comments on this change. Change subject: engine: add consoleAddress to migration command params ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/41222/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java: Line 177: getDestinationVds().getPort()); Line 178: Line 179: return new MigrateVDSCommandParameters(getVdsId(), getVmId(), srcVdsHost, getDestinationVdsId(), Line 180: dstVdsHost, MigrationMethod.ONLINE, isTunnelMigrationUsed(), getMigrationNetworkIp(), getVds().getVdsGroupCompatibilityVersion(), Line 181: getMaximumMigrationDowntime(), getAutoConverge(), getMigrateCompressed(), getVds().getConsoleAddress()); there is no bug nor feature page attached to this commit and the motivation for this patch isn't clear to me. for instance, should it be getVds().getConsoleAddress() or should it be getDestinationVds().getConsoleAddress() ? Line 182: } Line 183: Line 184: @Override Line 185: public void runningSucceded() { https://gerrit.ovirt.org/#/c/41222/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java: Line 52: Line 53: if (parameters.getMigrateCompressed() != null) { Line 54: migrationInfo.put(VdsProperties.MIGRATE_COMPRESSED, parameters.getMigrateCompressed().toString()); Line 55: } Line 56: is this applicable for any cluster level ? Line 57: if (parameters.getConsoleAddress() != null) { Line 58: migrationInfo.put(VdsProperties.CONSOLE_ADDRESS, parameters.getConsoleAddress()); Line 59: } Line 60: -- To view, visit https://gerrit.ovirt.org/41222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I788e713c279fc2c6c90b4609554383c067217add Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
