Sharad Mishra has uploaded a new change for review.
Change subject: core: Dead store to tempVar in
GetTagsByUserIdQuery.executeQueryCommand()
......................................................................
core: Dead store to tempVar in GetTagsByUserIdQuery.executeQueryCommand()
Fix findbugs issue -
GetTagsByUserIdQuery.java:14, DLS_DEAD_LOCAL_STORE, Priority: Low
Dead store to tempVar in
org.ovirt.engine.core.bll.GetTagsByUserIdQuery.executeQueryCommand()
This instruction assigns a value to a local variable, but the value is not read
or used in any subsequent instruction. Often, this indicates an error, because
the value computed is never used.
Note that Sun's javac compiler often generates dead stores for final local
variables. Because FindBugs is a bytecode-based tool, there is no easy way to
eliminate these false positives.
Change-Id: Ie2f021d90218f9cd7ec6bda52105d9367f41f2a3
Signed-off-by: Sharad Mishra <snmis...@linux.vnet.ibm.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagsByUserIdQuery.java
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/8682/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagsByUserIdQuery.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagsByUserIdQuery.java
index 9aa24a7..0d055d8 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagsByUserIdQuery.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagsByUserIdQuery.java
@@ -11,7 +11,6 @@
@Override
protected void executeQueryCommand() {
- VdcQueryParametersBase tempVar = getParameters();
getQueryReturnValue().setReturnValue(
DbFacade.getInstance().getTagDao()
.getAllForUsers((getParameters().getUserId())));
--
To view, visit http://gerrit.ovirt.org/8682
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2f021d90218f9cd7ec6bda52105d9367f41f2a3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
