Martin Peřina has posted comments on this change. Change subject: core: fix compensation for import and clone vm ......................................................................
Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/41213/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 207: protected final void postConstruct() { Line 208: // do not initialize for compensation Line 209: if (getParameters() != null) { Line 210: init(); Line 211: } > but that's true for all commands that use post-construct initialization - n If null parameters is the only indicator for creating instance due to compensation, then OK. Line 212: } Line 213: Line 214: /** Line 215: * Implement this method whenever you need extra initialization of the command after the -- To view, visit https://gerrit.ovirt.org/41213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e6d4b67d09537dedd167937e8949e7875d40a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
