Eli Mesika has posted comments on this change. Change subject: core:force bool fence agents options value ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41103/1/packaging/dbscripts/upgrade/03_06_1400_fix_bool_fence_agents_options.sql File packaging/dbscripts/upgrade/03_06_1400_fix_bool_fence_agents_options.sql: Line 10: -- force all 'secure' in options to be 'secure=1' Line 11: update fence_agents set options = replace(options, 'secure=1', 'TEMP_SECURE_EXPR') where not encrypt_options; Line 12: update fence_agents set options = replace(options, 'secure=true', 'TEMP_SECURE_EXPR') where not encrypt_options; Line 13: update fence_agents set options = replace(options, 'secure', 'secure=1') where not encrypt_options; Line 14: update fence_agents set options = replace(options, 'TEMP_SECURE_EXPR', 'secure=1') where not encrypt_options; > If we know of other boolean items that will fail now, we should use the opp We can go over the agents options in https://fedorahosted.org/cluster/wiki/FenceArguments and cover each such boolean flag that might be set by the admin using the free options field... What do you think ??? -- To view, visit https://gerrit.ovirt.org/41103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45f7a245dc01186f85619efd062c6f326c40d095 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
