Sahina Bose has posted comments on this change. Change subject: gluster: Corrected setting of gluster volume snapshot config ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41113/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeSnapshotConfigVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeSnapshotConfigVDSCommand.java: Line 23: .getConfgParam(); Line 24: Line 25: String paramValue = Line 26: cfgParam.getParamValue().endsWith("%") ? cfgParam.getParamValue().substring(0, Line 27: cfgParam.getParamValue().length() - 1) : cfgParam.getParamValue(); StringUtils.removeEnd would do? Line 28: if (cfgParam.getVolumeId() != null) { Line 29: GlusterVolumeEntity volume = DbFacade.getInstance().getGlusterVolumeDao().getById(cfgParam.getVolumeId()); Line 30: status = Line 31: getBroker().glusterVolumeSnapshotConfigSet(volume.getName(), -- To view, visit https://gerrit.ovirt.org/41113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5f425e9acd63646aad5ed4535cbc334c7b41aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
