Frank Kobzik has uploaded a new change for review. Change subject: engine: Wrong templates displayed for iscsi DC ......................................................................
engine: Wrong templates displayed for iscsi DC 1. Make sure you have iscsi,nfs local DCs. 2. Create templates for each DC 3. Try to create a pool for iscsi DC Wrong templates are listed in dropdown menu. The problem was caused by NPE in the Template_SelectedItemChanged method of the NewPoolModelBehavior class. The template is previously set to null in the ItemsChanged method of the ListModel class. Fixed by adding check for null in the Template_SelectedItemChanged method. Change-Id: I1dbee5e31ec945b8ee07407cac5045d7cf8c39bf Signed-off-by: Frantisek Kobzik <fkob...@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=863149 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/48/8648/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java index b90870b..44494e1 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java @@ -18,13 +18,16 @@ getModel().getTemplate().setSelectedItem(Linq.<VmTemplate> FirstOrDefault(templates)); } + @Override public void Template_SelectedItemChanged() { super.Template_SelectedItemChanged(); - VmTemplate template = (VmTemplate) getModel().getTemplate().getSelectedItem(); - setupWindowModelFrom(template); + if (template == null) { + return; + } + setupWindowModelFrom(template); updateHostPinning(template.getMigrationSupport()); doChangeDefautlHost(template.getdedicated_vm_for_vds()); } -- To view, visit http://gerrit.ovirt.org/8648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1dbee5e31ec945b8ee07407cac5045d7cf8c39bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
