Maor Lipchuk has posted comments on this change. Change subject: core: configurable format and type for base volume of template ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38376/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 224: createParams.setParentParameters(getParameters()); Line 225: createParams.setQuotaId(getQuotaIdForDisk(diskImage)); Line 226: createParams.setDiskProfileId(imageFromParams.getDiskProfileId()); Line 227: createParams.setVolumeFormat(imageFromParams.getVolumeFormat()); Line 228: createParams.setVolumeType(imageFromParams.getVolumeType()); I think you should add a CDA once you let the user choose the format and type. For example IINM sparse and raw should not be supported for block. Line 229: return createParams; Line 230: } Line 231: Line 232: private CloneCinderDisksParameters buildCinderChildCommandParameters(List<CinderDisk> cinderDisks, Guid vmSnapshotId) { -- To view, visit https://gerrit.ovirt.org/38376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ed39f0360c09799581f146b282e7ccadd1109d9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
