Moti Asayag has posted comments on this change.

Change subject: webadmin: Overload addTextAndLinkAlert with alert type
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/41021/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralInfoPresenter.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralInfoPresenter.java:

Line 178:      * @param text
Line 179:      *            the text content of the alert
Line 180:      * @param command
Line 181:      *            the command that should be executed when the link 
is clicked
Line 182:      * @param alertTtpe
> s/alertTtpe/alertType
Done
Line 183:      *            the type of the alert
Line 184:      */
Line 185:     private void addTextAndLinkAlert(final ViewDef view,
Line 186:             final String text,


Line 184:      */
Line 185:     private void addTextAndLinkAlert(final ViewDef view,
Line 186:             final String text,
Line 187:             final UICommand command,
Line 188:             final AlertType alertTtpe) {
> s/alertTtpe/alertType
Done
Line 189:         // Find the open and close positions of the link within the 
message:
Line 190:         final int openIndex = text.indexOf("<a>"); //$NON-NLS-1$
Line 191:         final int closeIndex = text.indexOf("</a>"); //$NON-NLS-1$
Line 192:         if (openIndex == -1 || closeIndex == -1 || closeIndex < 
openIndex) {


-- 
To view, visit https://gerrit.ovirt.org/41021
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3695d0b732d4f2139c18defa4809041cd62473f2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to