Moti Asayag has posted comments on this change. Change subject: engine: Avoid static access to DbFacade from VdsManager ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40939/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java: Line 254: AddVds(vds, false); Line 255: } Line 256: Line 257: public void AddVds(VDS vds, boolean isInternal) { Line 258: VdsManager vdsManager = new VdsManager(vds, auditLogDirector, this, dbFacade); > Actually why cant this be injected somehow as well? it will eventually Line 259: if (isInternal) { Line 260: VDSStatus status = vds.getStatus(); Line 261: switch (vds.getStatus()) { Line 262: case Error: -- To view, visit https://gerrit.ovirt.org/40939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie76e5e3c8f66287200c28d2afc9a51d3961cc244 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
