Moti Asayag has posted comments on this change.

Change subject: engine: Avoid static access to ResourceManager from 
HostMonitoring
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40937/2/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java
File 
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java:

Line 79:     public void setup() {
Line 80:         initVds();
Line 81:         initConditions();
Line 82:         when(vdsManager.getRefreshStatistics()).thenReturn(false);
Line 83:         updater = Mockito.spy(
> comment for future - please static import Mockito.spy
at the final patch it won't be used at all (the series of patches eliminate the 
need for using 'spy')
Line 84:                 new HostMonitoring(vdsManager, vds, 
mock(MonitoringStrategy.class), resourceManager) {
Line 85: 
Line 86:             @Override
Line 87:             public DbFacade getDbFacade() {


-- 
To view, visit https://gerrit.ovirt.org/40937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e3e08c5d502ce4139df2a2f7c46ff0d0503378
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to