Tomer Saban has uploaded a new change for review.
Change subject: webadmin: Showing the fault error in the multipleActions error
dialog
......................................................................
webadmin: Showing the fault error in the multipleActions error dialog
In most of the commands the canDoActionMessages contain the '$action'
and the '$type' replacements, no matter if the canDo passed or not.
Since FrontendEventsHandlerImpl.runMultipleActionsFailed checked the
canDoActionMessages size in order to decide wherer to show the canDo
errors or the fault, the fault was rarely (if ever) displayed.
Change-Id: I91819e7d67bbd76ec7c183608e0d0abbd70908ee
Signed-off-by: Alona Kaplan <alkap...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/99/41099/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
index 29ff396..833b88d 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
@@ -68,7 +68,7 @@
if (isRaiseErrorModalPanel(actions.get(actionNum++),
v.getFault())) {
String description =
(v.getDescription() != null &&
!"".equals(v.getDescription().trim())) || returnValues.size() == 1 ?
v.getDescription() : ConstantsManager.getInstance().getConstants().action() + "
" + actionNum; //$NON-NLS-1$ //$NON-NLS-2$
- if (!v.getCanDoActionMessages().isEmpty()) {
+ if (!v.getCanDoAction()) {
for (String canDo : v.getCanDoActionMessages()) {
errors.add(new Message(description, canDo));
}
--
To view, visit https://gerrit.ovirt.org/41099
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91819e7d67bbd76ec7c183608e0d0abbd70908ee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomer Saban <tsa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
