Shubhendu Tripathi has uploaded a new change for review.

Change subject: gluster: Fixed a coverity scan issue
......................................................................

gluster: Fixed a coverity scan issue

Fixed a coverity scan issue reported

Change-Id: If0d394e7077552341726506ab1e1e143dc3a717c
Signed-off-by: Shubhendu Tripathi <shtri...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotScheduleJob.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/41088/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotScheduleJob.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotScheduleJob.java
index afce8d0..bc68187 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotScheduleJob.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotScheduleJob.java
@@ -69,7 +69,7 @@
         GlusterVolumeSnapshotSchedule schedule =
                 
getGlusterVolumeSnapshotScheduleDao().getByVolumeId(volume.getId());
         Date endDate = 
GlusterUtil.getInstance().convertDate(schedule.getEndByDate(), 
schedule.getTimeZone());
-        if (endDate.before(new Date())) {
+        if (endDate != null && endDate.before(new Date())) {
             
getGlusterVolumeSnapshotScheduleDao().removeByVolumeId(volume.getId());
             logUtil.logAuditMessage(volume.getClusterId(),
                     volume,


-- 
To view, visit https://gerrit.ovirt.org/41088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If0d394e7077552341726506ab1e1e143dc3a717c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to