Eli Mesika has posted comments on this change. Change subject: core[DAO]: Adding external status to DAOs ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40994/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ExternalStatusAwareDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ExternalStatusAwareDao.java: Line 16: ExternalStatusAwareDao > Do we have other entities that will have external_status? And even if we do The answer is Yes I am going to implement external_status for SD and maybe for other entities as well in future This was implemented same as SatusAwareDao interface , so either both are right or both are wrong but consistency should be kept :-) -- To view, visit https://gerrit.ovirt.org/40994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4dd9a1bc0aa99604f74a07155a7b596585e3ccf Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
